Skip to content

Autoroll from main to staging - #11581

Merged
briantting merged 1 commit into
stagingfrom
autoroll-main-to-staging
Jul 28, 2026
Merged

Autoroll from main to staging#11581
briantting merged 1 commit into
stagingfrom
autoroll-main-to-staging

Conversation

@cobalt-github-releaser-bot

@cobalt-github-releaser-bot cobalt-github-releaser-bot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Automated cherry-pick roll to staging.

Original pull requests:

@rogerzanoni @anonymous1-me
Cherry pick PR #11335: nplb: use SIGUSR2 in KillSendsSignalToSelf
e289c5d 
Refer to original PR: #11335

SIGUSR1 is intercepted by the Android runtime and never reaches the
handler installed by the test. Switch the test to SIGUSR2.

Bug: 532068409

(cherry picked from commit b6c1a9d)
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/AUTOROLL hash and modifies the PosixSignalTest.KillSendsSignalToSelf test in posix_signal_test.cc to use SIGUSR2 instead of SIGUSR1. There are no review comments, and I have no feedback to provide.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message

starboard: Use SIGUSR2 in PosixSignalTest

Modify the KillSendsSignalToSelf test case to use SIGUSR2 instead of
SIGUSR1. This prevents potential interference from other system
processes or libraries that may use SIGUSR1, ensuring the NPLB POSIX
compliance tests are more robust.

Issue: 11335

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@briantting
briantting merged commit f378b5e into staging Jul 28, 2026
142 of 209 checks passed
@briantting
briantting deleted the autoroll-main-to-staging branch July 28, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briantting briantting briantting approved these changes
@linxinan-yt linxinan-yt Awaiting requested review from linxinan-yt
@oxve oxve Awaiting requested review from oxve
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cobalt-github-releaser-bot @briantting @rogerzanoni